Skip to content

Update Float8Tensor for GRPO training in unsloth#3158

Merged
andrewor14 merged 1 commit intomainfrom
unsloth-fp8-rl-test
Nov 7, 2025
Merged

Update Float8Tensor for GRPO training in unsloth#3158
andrewor14 merged 1 commit intomainfrom
unsloth-fp8-rl-test

Conversation

@andrewor14
Copy link
Copy Markdown
Contributor

@andrewor14 andrewor14 commented Oct 12, 2025 •
edited
Loading

Summary: Support a few extra ops called during GRPO loop in unsloth/vllm for Float8Tensor.

Test Plan:

python test/quantization/quantize_/workflows/float8/test_float8_tensor.py -k test_fp8_matmul_lora_variants
python test/quantization/quantize_/workflows/float8/test_float8_tensor.py -k test_to_dtype_layout
python test/quantization/quantize_/workflows/float8/test_float8_tensor.py -k test_has_compatible_shallow_copy_type
python test/quantization/quantize_/workflows/float8/test_float8_tensor.py -k test_transpose

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 left review comments

@vkuzo vkuzo vkuzo approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewor14 @vkuzo @jerryzh168